commit dc720843fe1f689466d2ab98ffcf22ce88b7510a
author Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Thu Sep 10 16:44:02 2020 -0400
committer Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Thu Sep 10 19:23:37 2020 -0400
tree 945d2173c95bc39d9075e4b56170f6e66fe4dc90
parent f1b4ede715791b7e2906189645a8bf2549a8ff7b

fix: memory leak

fix memory leaks related to
- image creation
- metal view

Change-Id: I2e5af4f06a7b22f671aa7dfecc4b4d68487d8599

src/AccSipGeneralVC.mm

diff --git a/src/AccSipGeneralVC.mm b/src/AccSipGeneralVC.mm
index 01577ca..697db38 100644
--- a/src/AccSipGeneralVC.mm
+++ b/src/AccSipGeneralVC.mm
@@ -124,16 +124,18 @@
 
 -(void)updateView {
     const auto& account = accountModel->getAccountInfo(self.selectedAccountID);
-    NSData *imageData = [[NSData alloc] initWithBase64EncodedString:account.profileInfo.avatar.toNSString() options:NSDataBase64DecodingIgnoreUnknownCharacters];
-    NSImage *image = [[NSImage alloc] initWithData:imageData];
-    if(image) {
-        [photoView setBordered:NO];
-        [photoView setImage: [image roundCorners: image.size.height * 0.5]];
-        [addProfilePhotoImage setHidden:YES];
-    } else {
-        [photoView setImage:nil];
-        [photoView setBordered:YES];
-        [addProfilePhotoImage setHidden:NO];
+    @autoreleasepool {
+        NSData *imageData = [[NSData alloc] initWithBase64EncodedString:account.profileInfo.avatar.toNSString() options:NSDataBase64DecodingIgnoreUnknownCharacters];
+        NSImage *image = [[NSImage alloc] initWithData:imageData];
+        if(image) {
+            [photoView setBordered:NO];
+            [photoView setImage: [image roundCorners: image.size.height * 0.5]];
+            [addProfilePhotoImage setHidden:YES];
+        } else {
+            [photoView setImage:nil];
+            [photoView setBordered:YES];
+            [addProfilePhotoImage setHidden:NO];
+        }
     }
     NSString* displayName = account.profileInfo.alias.toNSString();
     [displayNameField setStringValue:displayName];