commit 034eab3ee117a65d8f9a4fff71777dd338fa8075
author Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Tue Nov 17 14:59:41 2020 -0500
committer Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Tue Nov 17 16:14:51 2020 -0500
tree 86192153cc7152ff018538bb0186ee98e869761a
parent 24fe631adedf40f826b4cb9dfd31396c414bbae9

settings: save parameters only when editing finished

Change-Id: Ieaeb2d40cff9cf34337aae634289004ba37d39f9

src/AccAdvancedRingVC.mm

diff --git a/src/AccAdvancedRingVC.mm b/src/AccAdvancedRingVC.mm
index 9beedbc..b2efa4e 100644
--- a/src/AccAdvancedRingVC.mm
+++ b/src/AccAdvancedRingVC.mm
@@ -122,11 +122,9 @@
 
 #pragma mark - NSTextFieldDelegate methods
 
--(void)controlTextDidChange:(NSNotification *)notif
+-(void)controlTextDidEndEditing:(NSNotification *)notif
 {
     NSTextField *textField = [notif object];
-    NSRange test = [[textField currentEditor] selectedRange];
-
     [self valueDidChange:textField];
 }
 

src/AccAdvancedSipVC.mm

diff --git a/src/AccAdvancedSipVC.mm b/src/AccAdvancedSipVC.mm
index 663bad3..abab97d 100644
--- a/src/AccAdvancedSipVC.mm
+++ b/src/AccAdvancedSipVC.mm
@@ -354,11 +354,9 @@
 
 #pragma mark - NSTextFieldDelegate methods
 
--(void)controlTextDidChange:(NSNotification *)notif
+-(void)controlTextDidEndEditing:(NSNotification *)notif
 {
     NSTextField *textField = [notif object];
-    NSRange test = [[textField currentEditor] selectedRange];
-
     [self valueDidChange:textField];
 }
 

src/AccRingGeneralVC.mm

diff --git a/src/AccRingGeneralVC.mm b/src/AccRingGeneralVC.mm
index 93a4eec..ef9db62 100644
--- a/src/AccRingGeneralVC.mm
+++ b/src/AccRingGeneralVC.mm
@@ -297,15 +297,15 @@
 
 #pragma mark - NSTextFieldDelegate delegate methods
 
-- (void)controlTextDidChange:(NSNotification *)notif
+-(void)controlTextDidEndEditing:(NSNotification *)notification
 {
-    NSTextField* textField = [notif object];
+    NSTextField* textField = [notification object];
     if (textField.tag != DISPLAYNAME) {
         return;
     }
+
     NSString* displayName = textField.stringValue;
 
-    [NSObject cancelPreviousPerformRequestsWithTarget:self];
     self.accountModel->setAlias(self.selectedAccountID, QString::fromNSString(displayName));
     lrc::api::account::ConfProperties_t accountProperties = self.accountModel->getAccountConfig(self.selectedAccountID);
     self.accountModel->setAccountConfig(self.selectedAccountID, accountProperties);
@@ -423,6 +423,7 @@
     [self.view.window beginSheet: passwordWC.window completionHandler:nil];
 }
 - (IBAction)triggerAdwancedSettings: (NSButton *)sender {
+    [self.view.window makeFirstResponder:nil];
     [self.delegate triggerAdvancedOptions];
 }
 

src/AccSipGeneralVC.mm

diff --git a/src/AccSipGeneralVC.mm b/src/AccSipGeneralVC.mm
index 7bdff36..b9a720c 100644
--- a/src/AccSipGeneralVC.mm
+++ b/src/AccSipGeneralVC.mm
@@ -118,6 +118,7 @@
 }
 
 - (IBAction)triggerAdwancedSettings: (NSButton *)sender {
+     [self.view.window makeFirstResponder:nil];
      [self.delegate triggerAdvancedOptions];
 }
 
@@ -261,15 +262,13 @@
 
 #pragma mark - NSTextFieldDelegate delegate methods
 
-- (void)controlTextDidChange:(NSNotification *)notif
+-(void)controlTextDidEndEditing:(NSNotification *)notification
 {
-    NSTextField* textField = [notif object];
+    NSTextField* textField = [notification object];
     if (textField.tag != DISPLAYNAME) {
         return;
     }
     NSString* displayName = textField.stringValue;
-
-    [NSObject cancelPreviousPerformRequestsWithTarget:self];
     self.accountModel->setAlias(self.selectedAccountID, QString::fromNSString(displayName));
     lrc::api::account::ConfProperties_t accountProperties = self.accountModel->getAccountConfig(self.selectedAccountID);
     self.accountModel->setAccountConfig(self.selectedAccountID, accountProperties);