commit 8483442f76507d1ed4c839b4d7427caa24393c56
author Kateryna Kostiuk <katryna.kostiuk@savoirfairelinux.com> Tue Apr 11 10:53:56 2023 -0400
committer Kateryna Kostiuk <katryna.kostiuk@savoirfairelinux.com> Tue Apr 11 11:25:12 2023 -0400
tree e88ac336fdf8755faeb5690f6c626b15efbc1a37
parent da945d943e4d60122138e3166fb1a22038d669f3

notifications: fix memory leak in notification extension

- use weak delegate in adapter
- remove adapter delegate before extension stops

Change-Id: Icef7b9ea5f698c981da32a37083c8628b9a8fdbf

Ring/jamiNotificationExtension/AdapterService.swift

diff --git a/Ring/jamiNotificationExtension/AdapterService.swift b/Ring/jamiNotificationExtension/AdapterService.swift
index a39c9b1..f31441e 100644
--- a/Ring/jamiNotificationExtension/AdapterService.swift
+++ b/Ring/jamiNotificationExtension/AdapterService.swift
@@ -83,7 +83,7 @@
 
     private let maxSizeForAutoaccept = 20 * 1024 * 1024
 
-    private let adapter: Adapter
+    private var adapter: Adapter!
     var eventHandler: ((EventType, EventData) -> Void)?
     var loadingFiles = [String: EventData]()
 
@@ -118,8 +118,14 @@
         self.adapter.start(accountId)
     }
 
+    func removeDelegate() {
+        Adapter.delegate = nil
+        self.adapter = nil
+    }
+
     func stop() {
         self.adapter.stop()
+        removeDelegate()
     }
 
     func getNameFor(address: String, accountId: String) -> String {