commit 4e19133c3bb07a0977302f54bb06adae12dba4a8
author Andreas Traczyk <andreas.traczyk@savoirfairelinux.com> Wed Mar 21 20:46:48 2018 -0400
committer Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Wed Mar 21 21:09:37 2018 -0400
tree cb9ece719f13894bbc94faab4cacb1ea4da70d26
parent 638f92c3258df98934e1ef22c6b42757bbf0ac93

fix: avoid multiple binds on message cells in conversation view

Change-Id: I308b972c8d5a6042f0391116ef008c0a47fb2af7
Reviewed-by: Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com>

Ring/Ring/Features/Conversations/Conversation/ConversationViewController.swift

diff --git a/Ring/Ring/Features/Conversations/Conversation/ConversationViewController.swift b/Ring/Ring/Features/Conversations/Conversation/ConversationViewController.swift
index 8281d2d..f69bd15 100644
--- a/Ring/Ring/Features/Conversations/Conversation/ConversationViewController.swift
+++ b/Ring/Ring/Features/Conversations/Conversation/ConversationViewController.swift
@@ -746,7 +746,7 @@
                     .observeOn(MainScheduler.instance)
                     .filter {
                         return $0 != DataTransferStatus.unknown && $0 != item.lastTransferStatus && $0 != item.initialTransferStatus }
-                    .subscribe(onNext: { status in
+                    .subscribe(onNext: { [unowned self] status in
                         guard let currentIndexPath = tableView.indexPath(for: cell) else { return }
                         guard let transferId = item.daemonId else { return }
                         self.log.info("Transfer status change from: \(item.lastTransferStatus.description) to: \(status.description) for transferId: \(transferId) cell row: \(currentIndexPath.row)")
@@ -763,7 +763,7 @@
                     .disposed(by: cell.disposeBag)
 
                 cell.cancelButton.rx.tap
-                    .subscribe(onNext: { _ in
+                    .subscribe(onNext: { [unowned self] _ in
                         guard let transferId = item.daemonId else { return }
                         self.log.info("canceling transferId \(transferId)")
                         _ = self.viewModel.cancelTransfer(transferId: transferId)
@@ -776,7 +776,7 @@
 
                 if item.bubblePosition() == .received {
                     cell.acceptButton?.rx.tap
-                        .subscribe(onNext: { _ in
+                        .subscribe(onNext: { [unowned self] _ in
                             guard let transferId = item.daemonId else { return }
                             self.log.info("accepting transferId \(transferId)")
                             if self.viewModel.acceptTransfer(transferId: transferId, interactionID: item.messageId, messageContent: &item.message.content) != .success {