project: add static code analysis
This commit:
- adds swiftlint analysis as custom build phase
- to install, see: https://github.com/realm/SwiftLint
- fix almost every error/warning messages detected by swiftlint
Change-Id: I0d15cecaa33c4f79dcd1417a2169f1e66fd2e551
diff --git a/Ring/RingTests/ServiceEventTests.swift b/Ring/RingTests/ServiceEventTests.swift
index 6836c14..6f17c44 100644
--- a/Ring/RingTests/ServiceEventTests.swift
+++ b/Ring/RingTests/ServiceEventTests.swift
@@ -30,7 +30,7 @@
fileprivate var event: ServiceEvent?
override func setUp() {
- self.event = ServiceEvent(withEventType: .AccountsChanged)
+ self.event = ServiceEvent(withEventType: .accountsChanged)
}
/**
@@ -38,7 +38,7 @@
*/
func testCreateEvent() {
XCTAssertNotNil(self.event)
- XCTAssertTrue(self.event?.eventType == ServiceEventType.AccountsChanged)
+ XCTAssertTrue(self.event?.eventType == ServiceEventType.accountsChanged)
}
/**
@@ -46,9 +46,9 @@
*/
func testAddStringMetadata() {
let testString = "Identifier"
- self.event?.addEventInput(.Id, value: testString)
+ self.event?.addEventInput(.id, value: testString)
- let resultString: String = (self.event?.getEventInput(.Id))!
+ let resultString: String = (self.event?.getEventInput(.id))!
XCTAssertEqual(resultString, testString)
}
@@ -57,9 +57,9 @@
*/
func testAddIntMetadata() {
let testInt = 1
- self.event?.addEventInput(.Id, value: testInt)
+ self.event?.addEventInput(.id, value: testInt)
- let resultInt: Int = (self.event?.getEventInput(.Id))!
+ let resultInt: Int = (self.event?.getEventInput(.id))!
XCTAssertEqual(resultInt, testInt)
}
}