commit 9969d18114253a07787a33c93bb62f1ddcf24e16
author Benny Prijono <bennylp@teluu.com> Wed Apr 02 18:36:35 2008 +0000
committer Benny Prijono <bennylp@teluu.com> Wed Apr 02 18:36:35 2008 +0000
tree d0b6ed920937a0feaf018db84e07f739ccad9c58
parent f279d67118a0e22af000712fd7cc17e7ca21aa40

Ticket #520: Race condition may cause ioqueue corruption (thanks Philippe Leuba)

git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@1905 74dad513-b988-da41-8d7b-12977e46ad98

pjlib/src/pj/ioqueue_select.c

diff --git a/pjlib/src/pj/ioqueue_select.c b/pjlib/src/pj/ioqueue_select.c
index 0d90789..fdd0d9b 100644
--- a/pjlib/src/pj/ioqueue_select.c
+++ b/pjlib/src/pj/ioqueue_select.c
@@ -445,7 +445,10 @@
 
     pj_assert(ioqueue->count > 0);
     --ioqueue->count;
+#if !PJ_IOQUEUE_HAS_SAFE_UNREG
+    /* Ticket #520, key will be erased more than once */
     pj_list_erase(key);
+#endif
     PJ_FD_CLR(key->fd, &ioqueue->rfdset);
     PJ_FD_CLR(key->fd, &ioqueue->wfdset);
 #if PJ_HAS_TCP