commit 100368f9b45fce50994980396697af17fc2f3ac5
author Isa Nanic <isa.nanic@savoirfairelinux.com> Tue Dec 11 16:43:01 2018 -0500
committer Andreas Traczyk <andreas.traczyk@savoirfairelinux.com> Wed Dec 12 12:52:03 2018 -0500
tree e3e0f910d601032f55e8a6f0b52cdbab3201116c
parent 7548e73b0b7ca1be204090fe3ee1d37443478807

fix: remove programatic call to settings update functions

Change-Id: Ic7195bcbbafb5410edaeba15371799c81fedae32
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

settingswidget.cpp

diff --git a/settingswidget.cpp b/settingswidget.cpp
index 98a09c2..696c6c3 100644
--- a/settingswidget.cpp
+++ b/settingswidget.cpp
@@ -505,7 +505,7 @@
     bool ok = false;
     if (LRCInstance::getCurrAccConfig().archiveHasPassword) {
         psswd = QInputDialog::getText(this, tr("Remove Device"),
-            tr("Enter the password on this device to confirm the removal of this device"), QLineEdit::Password,
+            tr("Enter this account's password to confirm the removal of this device"), QLineEdit::Password,
             QDir::home().dirName(), &ok);
     }
     else {
@@ -684,7 +684,7 @@
         this, &SettingsWidget::updateAndShowDevicesSlot);
 
     // account settings setters {
-    connect(ui->accountEnableCheckBox, &QCheckBox::stateChanged, this, &SettingsWidget::setAccEnableSlot);
+    connect(ui->accountEnableCheckBox, &QAbstractButton::clicked, this, &SettingsWidget::setAccEnableSlot);
 
     connect(ui->displayNameLineEdit, &QLineEdit::textChanged, [this](const QString& displayName) {
         LRCInstance::setCurrAccDisplayName(displayName.toStdString());
@@ -693,19 +693,19 @@
 
     // general settings
 
-    connect(ui->notificationCheckBox, &QCheckBox::stateChanged, this, &SettingsWidget::setNotificationsSlot);
+    connect(ui->notificationCheckBox, &QAbstractButton::clicked, this, &SettingsWidget::setNotificationsSlot);
 
-    connect(ui->closeOrMinCheckBox, &QCheckBox::stateChanged, this, &SettingsWidget::setClosedOrMinSlot);
+    connect(ui->closeOrMinCheckBox, &QAbstractButton::clicked, this, &SettingsWidget::setClosedOrMinSlot);
 
-    connect(ui->downloadButton, &QPushButton::clicked, this, &SettingsWidget::openDownloadFolderSlot);
+    connect(ui->downloadButton, &QAbstractButton::clicked, this, &SettingsWidget::openDownloadFolderSlot);
 
-    connect(ui->alwaysRecordingCheckBox, &QCheckBox::stateChanged, this, &SettingsWidget::setAlwaysRecordingSlot);
+    connect(ui->alwaysRecordingCheckBox, &QAbstractButton::clicked, this, &SettingsWidget::setAlwaysRecordingSlot);
 
-    connect(ui->checkUpdateButton, &QPushButton::clicked, this, &SettingsWidget::checkForUpdateSlot);
+    connect(ui->checkUpdateButton, &QAbstractButton::clicked, this, &SettingsWidget::checkForUpdateSlot);
 
     connect(ui->intervalUpdateCheckSpinBox, QOverload<int>::of(&QSpinBox::valueChanged), this, &SettingsWidget::setUpdateIntervalSlot);
 
-    connect(ui->autoUpdateCheckBox, &QCheckBox::stateChanged, this, &SettingsWidget::setUpdateAutomaticSlot);
+    connect(ui->autoUpdateCheckBox, &QAbstractButton::clicked, this, &SettingsWidget::setUpdateAutomaticSlot);
 
     // audio / visual settings