commit c8035c6f0798336b97a3cbd5c56868c990ca2c6e
author Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Wed Sep 19 16:13:14 2018 -0400
committer Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Thu Sep 20 09:17:03 2018 -0400
tree 3cef26acd5f6476d6e5148a50b26b9ba3533e5eb
parent 255d7c27658956ca7d407d27826a1a19379fbb38

fix: crash on deselect conversation

This patch ensure that new cells are not created when changing
conversation selections since it could lead to crash if conversation
filter was updated.

Change-Id: I28cd358deba1fe15ded7a64b06dd09f1bb43488e

src/SmartViewVC.mm

diff --git a/src/SmartViewVC.mm b/src/SmartViewVC.mm
index 25d0fb2..ed2d41d 100755
--- a/src/SmartViewVC.mm
+++ b/src/SmartViewVC.mm
@@ -191,6 +191,7 @@
     }
 
     [smartView reloadData];
+    [smartView layoutSubtreeIfNeeded];
 
     if (!selectedUid_.empty() && convModel_ != nil) {
         auto it = getConversationFromUid(selectedUid_, *convModel_);
@@ -383,7 +384,7 @@
     NSInteger rows = [smartView numberOfRows];
 
     for (int i = 0; i< rows; i++) {
-        NSTableRowView* cellRowView = [smartView rowViewAtRow:i makeIfNecessary:YES];
+        NSTableRowView* cellRowView = [smartView rowViewAtRow:i makeIfNecessary: NO];
         if (i == row) {
             cellRowView.backgroundColor = [NSColor controlColor];
         } else {