commit 9dd759cdc92e32429b8853ed12311c1a76245c74
author Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Tue Jul 11 12:06:55 2017 -0400
committer Kateryna Kostiuk <kateryna.kostiuk@savoirfairelinux.com> Wed Jul 12 11:13:47 2017 -0400
tree e42a3ec3e1ddb1d7cf768a3b549ff2da2bcedee6
parent b90f92afbbd92f2ad58fc4decfa311a152af370b

Smart View: contextual menu for not selected row

Contextual menu item - "add contact" works only when row is selected.
This patch change it and now contact could be added regardless of row
selection.

Change-Id: I1f0ec195c478faf46de031c8b4ac38a0469116ba
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

src/HistoryVC.mm

diff --git a/src/HistoryVC.mm b/src/HistoryVC.mm
index 5fae480..514a389 100644
--- a/src/HistoryVC.mm
+++ b/src/HistoryVC.mm
@@ -230,10 +230,12 @@
             if (!contactmethod->contact() || contactmethod->contact()->isPlaceHolder()) {
                 NSMenu *theMenu = [[NSMenu alloc]
                                    initWithTitle:@""];
-                [theMenu insertItemWithTitle:NSLocalizedString(@"Add to contacts", @"Contextual menu action")
-                                      action:@selector(addToContact)
-                               keyEquivalent:@"a"
-                                     atIndex:0];
+                NSMenuItem* addContactItem = [[NSMenuItem alloc] initWithTitle:NSLocalizedString(@"Add to contacts", @"Contextual menu action")
+                                                                        action:@selector(addContactForRow:)
+                                                                 keyEquivalent:@""];
+
+                [addContactItem setRepresentedObject:item];
+                [theMenu addItem:addContactItem];
                 return theMenu;
             }
         }
@@ -272,6 +274,16 @@
     }
 }
 
+- (void) addContactForRow:(id) sender
+{
+    NSInteger row = [historyView rowForItem:[sender representedObject]];
+    if(row < 0) {
+        return;
+    }
+    [historyView selectRowIndexes:[NSIndexSet indexSetWithIndex:row] byExtendingSelection:NO];
+    [self addToContact];
+}
+
 #pragma mark - NSPopOverDelegate
 
 - (void)popoverDidClose:(NSNotification *)notification

src/SmartViewVC.mm

diff --git a/src/SmartViewVC.mm b/src/SmartViewVC.mm
index 0b99107..948346a 100644
--- a/src/SmartViewVC.mm
+++ b/src/SmartViewVC.mm
@@ -477,6 +477,16 @@
     }
 }
 
+- (void) addContactForRow:(id) sender
+{
+    NSInteger row = [smartView rowForItem:[sender representedObject]];
+    if(row < 0) {
+        return;
+    }
+    [smartView selectRowIndexes:[NSIndexSet indexSetWithIndex:row] byExtendingSelection:NO];
+    [self addToContact];
+}
+
 /**
  Copy a NSString in the general Pasteboard
 
@@ -572,10 +582,11 @@
         && !contactmethods.first()->contact()
         || contactmethods.first()->contact()->isPlaceHolder()) {
 
-        [theMenu insertItemWithTitle:NSLocalizedString(@"Add to contacts", @"Contextual menu action")
-                              action:@selector(addToContact)
-                       keyEquivalent:@"a"
-                             atIndex:theMenu.itemArray.count];
+        NSMenuItem* addContactItem = [[NSMenuItem alloc] initWithTitle:NSLocalizedString(@"Add to contacts", @"Contextual menu action")
+                                                                action:@selector(addContactForRow:)
+                                                         keyEquivalent:@""];
+        [addContactItem setRepresentedObject:item];
+        [theMenu addItem:addContactItem];
     } else if (auto person = contactmethods.first()->contact()) {
         NSMenuItem* copyNameItem = [[NSMenuItem alloc] initWithTitle:NSLocalizedString(@"Copy name", @"Contextual menu action")
                                                              action:@selector(copyStringToPasteboard:)