commit fad674f560cb9a07902b4058ba0c938299ae036c
author Nicolas Jager <nicolas.jager@savoirfairelinux.com> Thu Oct 19 11:35:36 2017 -0400
committer Guillaume Roguez <guillaume.roguez@savoirfairelinux.com> Thu Oct 19 11:37:04 2017 -0400
tree 7d09a497da089981bf78a7a0faedceb6f91bbc58
parent d532c74f92380bad137f65dcacaf69721ac27895

hardening delete operator

Make sure that delete operator is not called with invalid pointers.

Change-Id: I822b670c63bd40234aef0213517914fdcc7b68e9
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

src/accountsecuritytab.cpp

diff --git a/src/accountsecuritytab.cpp b/src/accountsecuritytab.cpp
index d298aaa..e3a23f0 100644
--- a/src/accountsecuritytab.cpp
+++ b/src/accountsecuritytab.cpp
@@ -109,7 +109,10 @@
     AccountSecurityTab *view = ACCOUNT_SECURITY_TAB(object);
     AccountSecurityTabPrivate *priv = ACCOUNT_SECURITY_TAB_GET_PRIVATE(view);
 
-    delete priv->qmodel_key_exchange;
+    if (priv->qmodel_key_exchange) {
+        delete priv->qmodel_key_exchange;
+        priv->qmodel_key_exchange = nullptr;
+    }
 
     G_OBJECT_CLASS(account_security_tab_parent_class)->finalize(object);
 }