commit cbb2fc48ed76cddca1405750d7524a1ad0350f26
author aviau <alexandre@alexandreviau.net> Mon Dec 12 15:55:24 2016 -0500
committer Alexandre Viau <alexandre@alexandreviau.net> Tue Dec 13 10:39:28 2016 -0500
tree 2c7f4e97335e777da834c9dc9267a886e3007465
parent b135a69f65d0b61ac3f9e8504d49cc856e5700d8

Hide ice fallback settings for non-Ring accounts

ICE fallback features are not relevant to Ring accounts,
as every Ring client supports ICE.

Tuleap: #1408
Change-Id: I28381e74e7388e4d1ed25aa1a8918fefe0c8a133

src/accountadvancedtab.cpp

diff --git a/src/accountadvancedtab.cpp b/src/accountadvancedtab.cpp
index 0faadd6..497e482 100644
--- a/src/accountadvancedtab.cpp
+++ b/src/accountadvancedtab.cpp
@@ -65,6 +65,7 @@
     GtkWidget *entry_turnusername;
     GtkWidget *entry_turnpassword;
     GtkWidget *entry_turnrealm;
+    GtkWidget *frame_ice_fallback;
     GtkWidget *adjustment_audio_port_min;
     GtkWidget *adjustment_audio_port_max;
     GtkWidget *adjustment_video_port_min;
@@ -130,6 +131,7 @@
     gtk_widget_class_bind_template_child_private(GTK_WIDGET_CLASS (klass), AccountAdvancedTab, entry_turnusername);
     gtk_widget_class_bind_template_child_private(GTK_WIDGET_CLASS (klass), AccountAdvancedTab, entry_turnpassword);
     gtk_widget_class_bind_template_child_private(GTK_WIDGET_CLASS (klass), AccountAdvancedTab, entry_turnrealm);
+    gtk_widget_class_bind_template_child_private(GTK_WIDGET_CLASS (klass), AccountAdvancedTab, frame_ice_fallback);
     gtk_widget_class_bind_template_child_private(GTK_WIDGET_CLASS (klass), AccountAdvancedTab, adjustment_audio_port_min);
     gtk_widget_class_bind_template_child_private(GTK_WIDGET_CLASS (klass), AccountAdvancedTab, adjustment_audio_port_max);
     gtk_widget_class_bind_template_child_private(GTK_WIDGET_CLASS (klass), AccountAdvancedTab, adjustment_video_port_min);
@@ -458,6 +460,13 @@
                      "changed", G_CALLBACK(turn_serverrealm_changed), self);
 
     /* audio/video rtp port range */
+
+    /* ice fallback features are not relevant to Ring account, as every RING
+       client supports ICE */
+    gtk_widget_set_visible(
+        priv->frame_ice_fallback,
+        priv->account->protocol() != Account::Protocol::RING
+    );
     gtk_adjustment_set_value(GTK_ADJUSTMENT(priv->adjustment_audio_port_min),
                              priv->account->audioPortMin());
     g_signal_connect(priv->adjustment_audio_port_min,