commit 395931bac557f663b105902b4618bbe616474df0
author Hugo Lefeuvre <hugo.lefeuvre@savoirfairelinux.com> Tue Jul 17 12:13:14 2018 -0400
committer Sébastien Blin <sebastien.blin@savoirfairelinux.com> Fri Aug 10 14:16:13 2018 -0400
tree 1abf45168cd10abd4b28445e9f3da2121245b5dc
parent 2ae7f2aef6bdc4d7ac97e97737d236d92c37765f

accountcreation: improve small screens support

Switch AccountCreationWizard type to GtkScrolledWindow to make it
resizable.

Change-Id: I964a92f2b1b7918193b71895b35f0d4b5f3198a1
Gitlab: #885
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

src/accountcreationwizard.cpp

diff --git a/src/accountcreationwizard.cpp b/src/accountcreationwizard.cpp
index 9888044..dc5504d 100644
--- a/src/accountcreationwizard.cpp
+++ b/src/accountcreationwizard.cpp
@@ -38,12 +38,12 @@
 
 struct _AccountCreationWizard
 {
-    GtkBox parent;
+    GtkScrolledWindow parent;
 };
 
 struct _AccountCreationWizardClass
 {
-    GtkBoxClass parent_class;
+    GtkScrolledWindowClass parent_class;
 };
 
 typedef struct _AccountCreationWizardPrivate AccountCreationWizardPrivate;
@@ -106,7 +106,7 @@
 
 };
 
-G_DEFINE_TYPE_WITH_PRIVATE(AccountCreationWizard, account_creation_wizard, GTK_TYPE_BOX);
+G_DEFINE_TYPE_WITH_PRIVATE(AccountCreationWizard, account_creation_wizard, GTK_TYPE_SCROLLED_WINDOW);
 
 #define ACCOUNT_CREATION_WIZARD_GET_PRIVATE(obj) (G_TYPE_INSTANCE_GET_PRIVATE ((obj), ACCOUNT_CREATION_WIZARD_TYPE, AccountCreationWizardPrivate))
 
@@ -387,6 +387,12 @@
 show_choose_account_type(AccountCreationWizard *view)
 {
     AccountCreationWizardPrivate *priv = ACCOUNT_CREATION_WIZARD_GET_PRIVATE(view);
+
+    /* Make sure other stack elements are hidden, otherwise their width will prevent
+       the window to be correctly resized at this stage. */
+    gtk_widget_hide(priv->account_creation);
+    gtk_widget_hide(priv->existing_account);
+
     gtk_stack_set_visible_child(GTK_STACK(priv->stack_account_creation), priv->choose_account_type_vbox);
 }
 
@@ -402,6 +408,8 @@
 show_existing_account(AccountCreationWizard *view)
 {
     AccountCreationWizardPrivate *priv = ACCOUNT_CREATION_WIZARD_GET_PRIVATE(view);
+
+    gtk_widget_show(priv->existing_account);
     gtk_stack_set_visible_child(GTK_STACK(priv->stack_account_creation), priv->existing_account);
 }
 
@@ -605,7 +613,14 @@
 {
     AccountCreationWizardPrivate *priv = ACCOUNT_CREATION_WIZARD_GET_PRIVATE(win);
 
-    /* Similarly to general settings view, we construct and destroy the avatar manipulation widget
+    if (priv->account_creation) {
+        if (show_preview)
+            gtk_widget_show(priv->account_creation);
+        else
+            gtk_widget_hide(priv->account_creation);
+    }
+
+    /* Similarily to general settings view, we construct and destroy the avatar manipulation widget
        each time the profile is made visible / hidden. While not the most elegant solution, this
        allows us to run the preview if and only if it is displayed, and always stop it when hidden. */
     if (show_preview && !priv->avatar_manipulation) {