commit 131795243a94e66ae957eb7046c21c813aa52552
author Emeric Vigier <emeric.vigier@savoirfairelinux.com> Tue Nov 06 17:44:21 2012 -0500
committer Emeric Vigier <emeric.vigier@savoirfairelinux.com> Tue Nov 06 19:12:56 2012 -0500
tree 31c8a28f4621a410ec38ea5915070a347f020ce5
parent b16eed39d63b6174d0b673e27c51e68d3ebd41ff

#17382: Fix ThreadAlreadyStarted exception

src/com/savoirfairelinux/sflphone/service/SipService.java

diff --git a/src/com/savoirfairelinux/sflphone/service/SipService.java b/src/com/savoirfairelinux/sflphone/service/SipService.java
index c619970..0a156e7 100644
--- a/src/com/savoirfairelinux/sflphone/service/SipService.java
+++ b/src/com/savoirfairelinux/sflphone/service/SipService.java
@@ -278,24 +278,25 @@
         Log.i(TAG, "onStarted");
         super.onStartCommand(intent, flags, startId);
 
-        runFlag = true;
-        sipServiceThread.start();
-        sflphoneApp.setServiceRunning(true);
-        Toast.makeText(this, "Sflphone Service started", Toast.LENGTH_SHORT).show();
+        if (!runFlag) {
+            sipServiceThread.start();
+            runFlag = true;
+            sflphoneApp.setServiceRunning(true);
+            Toast.makeText(this, "Sflphone Service started", Toast.LENGTH_SHORT).show();
+        }
 
-        Log.i(TAG, "onStarted");
         return START_STICKY; /* started and stopped explicitly */
     }
 
     @Override
     public void onDestroy() {
         /* called once by stopService() */
-        super.onDestroy();
-        runFlag = false;
         sipServiceThread.interrupt();
         sipServiceThread = null;
+        runFlag = false;
         sflphoneApp.setServiceRunning(false);
         Toast.makeText(this, "Sflphone Service stopped", Toast.LENGTH_SHORT).show();
+        super.onDestroy();
         
         Log.i(TAG, "onDestroyed");
     }