commit d78d1acb2b4c98aeb500b18e632f735472ade43b
author Adrien Béraud <adrien.beraud@savoirfairelinux.com> Fri Aug 25 10:43:33 2023 -0400
committer Adrien Béraud <adrien.beraud@savoirfairelinux.com> Sun Aug 27 12:54:15 2023 -0400
tree 84d5293bd04fbc0ae320e8d2cf0996c0aaea5eb7
parent 2a4e73d24834872121a8ad36e6f52eb4ba006781

fix various warnings

Change-Id: Iecf54a3a0368c99705969679fe18ceda59ce4290

src/upnp/protocol/pupnp/pupnp.cpp

diff --git a/src/upnp/protocol/pupnp/pupnp.cpp b/src/upnp/protocol/pupnp/pupnp.cpp
index e5e1a42..d1feed9 100644
--- a/src/upnp/protocol/pupnp/pupnp.cpp
+++ b/src/upnp/protocol/pupnp/pupnp.cpp
@@ -78,7 +78,7 @@
 }
 
 static bool
-errorOnResponse(IXML_Document* doc)
+errorOnResponse(IXML_Document* doc, const std::shared_ptr<dht::log::Logger>& logger)
 {
     if (not doc)
         return true;
@@ -86,9 +86,9 @@
     auto errorCode = getFirstDocItem(doc, "errorCode");
     if (not errorCode.empty()) {
         auto errorDescription = getFirstDocItem(doc, "errorDescription");
-        // if (logger_) logger_->warn("PUPnP: Response contains error: {:s}: {:s}",
-        //           errorCode,
-        //           errorDescription);
+        if (logger) logger->warn("PUPnP: Response contains error: {:s}: {:s}",
+                  errorCode,
+                  errorDescription);
         return true;
     }
     return false;
@@ -1154,7 +1154,7 @@
     }
     XMLDocument response(response_container_ptr, ixmlDocument_free);
 
-    if (errorOnResponse(response.get())) {
+    if (errorOnResponse(response.get(), logger_)) {
         if (logger_) logger_->warn("PUPnP: Failed to get GetStatusInfo from {} -> {:d}: {}",
                   igd.getServiceType().c_str(),
                   upnp_err,
@@ -1206,7 +1206,7 @@
         return {};
     }
 
-    if (errorOnResponse(response.get())) {
+    if (errorOnResponse(response.get(), logger_)) {
         if (logger_) logger_->warn("PUPnP: Failed to get GetExternalIPAddress from {} -> {:d}: {}",
                   igd.getServiceType(),
                   upnp_err,