commit d1e018ca4b0996a298b86a160268abb3f11b50cd
author Sébastien Blin <sebastien.blin@savoirfairelinux.com> Fri Sep 01 09:15:12 2023 -0400
committer Sébastien Blin <sebastien.blin@savoirfairelinux.com> Fri Sep 01 09:15:12 2023 -0400
tree 0ff189689ce86f615100fb3826b4fbf98e120414
parent c453ca7f8115449d5c512948711b53ecc8410503

natpmp: pass shared pointer to timer to avoid crash

Change-Id: I1fbf84f8fb10b14390abb951b8ed312716047936

src/upnp/protocol/natpmp/nat_pmp.cpp

diff --git a/src/upnp/protocol/natpmp/nat_pmp.cpp b/src/upnp/protocol/natpmp/nat_pmp.cpp
index c5e8ce6..48e010a 100644
--- a/src/upnp/protocol/natpmp/nat_pmp.cpp
+++ b/src/upnp/protocol/natpmp/nat_pmp.cpp
@@ -186,9 +186,11 @@
 
             // Cancel the current timer (if any) and re-schedule.
             searchForIgdTimer_.expires_after(NATPMP_SEARCH_RETRY_UNIT * igdSearchCounter_);
-            searchForIgdTimer_.async_wait([this](const asio::error_code& ec) {
-                if (!ec)
-                    searchForIgd();
+            searchForIgdTimer_.async_wait([w=weak()](const asio::error_code& ec) {
+                if (!ec) {
+                    if (auto shared = w.lock())
+                        shared->searchForIgd();
+                }
             });
         } else {
             if (logger_) logger_->warn("NAT-PMP: Setup failed after {} trials. NAT-PMP will be disabled!",