commit 2ef5b66c07b67af2193da48d54a00af38b7b425d
author François-Simon Fauteux-Chapleau <francois-simon.fauteux-chapleau@savoirfairelinux.com> Wed Mar 27 12:30:26 2024 -0400
committer François-Simon Fauteux-Chapleau <francois-simon.fauteux-chapleau@savoirfairelinux.com> Fri Mar 29 12:29:09 2024 -0400
tree 2dba16a5a5820603b32bce290aa95c54a074867e
parent 9176131a62881cc02437c26959addfe48c151198

ice/turn transport: make sure PJSIP is initialized before it's used

Using PJSIP functions without calling pj_init first can lead to subtle
non-deterministic bugs.

GitLab: #18
Change-Id: I9364fd247165c0ce19a8d0d42575fb66651b54a3

src/turn/turn_transport.cpp

diff --git a/src/turn/turn_transport.cpp b/src/turn/turn_transport.cpp
index 3ed4015..75525ff 100644
--- a/src/turn/turn_transport.cpp
+++ b/src/turn/turn_transport.cpp
@@ -147,7 +147,8 @@
 }
 
 TurnTransport::TurnTransport(const TurnTransportParams& params, std::function<void(bool)>&& cb, const std::shared_ptr<Logger>& logger)
-    : pimpl_ {new Impl(std::move(cb), logger)}
+    : pjInitLock_()
+    , pimpl_ {new Impl(std::move(cb), logger)}
 {
     auto server = params.server;
     if (!server.getPort())

src/turn/turn_transport.h

diff --git a/src/turn/turn_transport.h b/src/turn/turn_transport.h
index b872454..37626b8 100644
--- a/src/turn/turn_transport.h
+++ b/src/turn/turn_transport.h
@@ -17,6 +17,7 @@
 #pragma once
 
 #include "ip_utils.h"
+#include "pj_init_lock.h"
 #include "turn_params.h"
 
 #include <opendht/logger.h>
@@ -48,6 +49,7 @@
 
 private:
     TurnTransport() = delete;
+    PjInitLock pjInitLock_;
     class Impl;
     std::unique_ptr<Impl> pimpl_;
 };