commit 26365c938f1868e8a034ef8d38eb81be39f09c7b
author Adrien Béraud <adrien.beraud@savoirfairelinux.com> Sat Sep 23 23:42:43 2023 -0400
committer Adrien Béraud <adrien.beraud@savoirfairelinux.com> Sat Sep 23 23:52:26 2023 -0400
tree bab64fe3122fbafb1fe8caa5f14a2b957d92b235
parent 651a4c6f7f98728a57b7b2e6746108b6e4b0967b

ConnectionManager: avoid duplicate IDs

Change-Id: Ie56f065a58b9a5453d3b2df86cd7a7b249fac077

src/connectionmanager.cpp

diff --git a/src/connectionmanager.cpp b/src/connectionmanager.cpp
index 339c8d5..67623b2 100644
--- a/src/connectionmanager.cpp
+++ b/src/connectionmanager.cpp
@@ -747,15 +747,16 @@
             cb(nullptr, deviceId);
             return;
         }
-        dht::Value::Id vid = ValueIdDist(1, ID_MAX_VAL)(sthis->rand);
+        dht::Value::Id vid;
         auto isConnectingToDevice = false;
         {
             std::lock_guard<std::mutex> lk(sthis->connectCbsMtx_);
+            vid = ValueIdDist(1, ID_MAX_VAL)(sthis->rand);
             auto pendingsIt = sthis->pendingOperations_.find(deviceId);
             if (pendingsIt != sthis->pendingOperations_.end()) {
                 const auto& pendings = pendingsIt->second;
                 while (pendings.connecting.find(vid) != pendings.connecting.end()
-                       && pendings.waiting.find(vid) != pendings.waiting.end()) {
+                    || pendings.waiting.find(vid) != pendings.waiting.end()) {
                     vid = ValueIdDist(1, ID_MAX_VAL)(sthis->rand);
                 }
             }